Do not lock dependencies to minor version #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overly restrictive version locks will cause unnecessary issues for downstream applications. All gems should be following semver, such that minor version bumps are completely backwards compatible. Fuzzy locking to a specific minor version will also allow you to use new functionality if it was added in a backwards compatible minor version update.
|
It appears I can't see why CircleCI is failing without creating an account. Github actions avoids this issue, and provides pretty in-depth CI/CD integrations. |
|
Hey @athix thanks for raising the PR. The tests are failing locally as well. It looks to be an issue with rest client 2.1.0 |
davidpatrick
approved these changes
Jul 20, 2021
🤦♂️ It's frustrating that rest-client isn't following semver... Also I took a look and it seems like the library might be unmaintained at the moment, which is a bit concerning. I created an issue to ask about this: rest-client/rest-client#764 Thanks for tracking down what the problem was! 🙂 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overly restrictive version locks will cause unnecessary issues for downstream applications. All gems should be following semver, such that minor version bumps are completely backwards compatible. By fuzzy locking to the minor version that you need, you both allow upgrading to compatible newer versions, while also ensuring the inclusion of functionality that may have been introduced in a minor version.