-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildcard certificates #97
Comments
I'm not a repo maintainer but I have to say this is not something easy to add. LE wildcard certificates will require DNS validation, and right now lua-resty-auto-ssl uses http validation. |
DNS validation would be nice to have, even not considering wildcards. A few thoughts:
Questions:
|
FYI: there is now a ACMEv2 staging endpoint available. :) |
You're right :-) Nothing has changed in the DNS-01 challenge between the V1 and V2 API. |
FYI: at least the development version of dehydrated now supports ACMEv2 as well as wildcard certificates. In case anyone wants to start working on this, now is your chance ;) |
I think resty-auto-ssl doing DNS validation is completely out of scope. EDIT: well, it's not that out of scope. I did not know dehydrated could be configured with manual scripts to hook into a custom DNS api... |
Is there a way to store a manually generated wildcard LE certificate to Redis so that resty-auto-ssl could use it ? |
From what I understand from the code, this is not possible. We could easily add the following checks though in the storage interface, for each
This way, we could have a first step towards wildcards, supporting only previously generated certificates for now. After doing so, we could move on and decide on a nice way to support generation of wildcard certificates, if we decide we want to do so. Edit: I'd be happy to scratch an implementation of the above. |
@akalipetis did you try to see if setting
would work in allow_domain ? |
For the record I just hit this issue, I use I achieved this by using the auto_ssl:set("allow_domain", function(domain)
return not ngx.re.match(domain, "status.updown.io$", "ijo")
end) And then provided the wildcard as the default fallback cert: ssl_certificate /etc/letsencrypt/live/status.updown.io/fullchain.pem;
ssl_certificate_key /etc/letsencrypt/live/status.updown.io/privkey.pem; I generated the cert manually using the DNS challenge with: sudo certbot certonly --manual -d *.status.updown.io --agree-tos --no-bootstrap --manual-public-ip-logging-ok I'm not sure it's worth spending my time automating this as it looks complicated with the DNS challenge. It's low tech but it works as expected :) |
That's a nice workaround, and one that applies to many use cases. |
@kapouer thanks for the tip about |
I am also doing the same type of domain check for our app. If the user's portal host contains one of our "own" domains, then we just revert to using wildcard certs from a static CA. But I like your idea of still using LE and generating the wildcards manually. I'm going to test this out. Update |
@jarthod any other workaround to automate this? Remembering to renew wildcard every 3 month is pain actually. |
Not on my side, I'm still using this and doing the manual renew every 3 months. Remembering is not a problem for me as I'm using my service (updown.io) to monitor the endpoint and it does alert me when the cert is about to expire. |
I am also user of your service. Anyway I went ahead and got traditional 1 year wildcard SSL.
Now your service has job to remind me next year 😄
… On 03-Oct-2020, at 10:30 PM, Adrien Rey-Jarthon ***@***.***> wrote:
@jarthod any other workaround to automate this? Remembering to renew wildcard every 3 month is pain actually.
Not on my side, I'm still using this and doing the manual renew every 3 months. Remembering is not a problem for me as I'm using my service (updown.io) to monitor the endpoint and it does alert me when the cert is about to expire.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Hi,
Just wondering how long it will take to update to issuing wildcards come January? You think it's a big change?
The text was updated successfully, but these errors were encountered: