From 5ea3ad12ca6aeac90561bfc247ef6948d238be53 Mon Sep 17 00:00:00 2001 From: Maru Newby Date: Wed, 8 Jan 2025 10:20:51 -0800 Subject: [PATCH] [ci] Fix post-merge protobuf lint job breakage Without push being explicitly disabled on the lint job, it will attempt to push when run post-merge. Without a buf token, that push will fail. The `buf-push` is responsible for pushing so there's no reason for the lint job to attempt it. --- .github/workflows/ci.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f63cf7f71e8d..3c6fdc5a7a05 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -133,6 +133,10 @@ jobs: with: input: "proto" pr_comment: false + # buf-action defaults to pushing on non-fork branch pushes + # which is never desirable for this job. The buf-push job is + # responsible for pushes. + push: false version: 1.35.0 check_generated_protobuf: name: Up-to-date protobuf