[wip] testing subnet-evm sync workflow #636
Draft
+47
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
reviewed
Aug 22, 2024
Comment on lines
+44
to
+47
| - name: Restore .github/workflows | ||
| run: | | ||
| git checkout -- .github/workflows |
There was a problem hiding this comment.
AFAIK it requires a special token if you want to modify a workflow with a workflow
ceyonur
reviewed
Aug 22, 2024
There was a problem hiding this comment.
This looks dope. Once upon a time I tried to come up with a similar workflow but ended up needing a special token. I think this script won't require token since it creates the PR in the same repo (coreth). What I had been previously trying to accomplish was:
- Once a PR is merged in Subnet-EVM master, create a subsequent PR in coreth by cherry-picking those commits. The workflow can poll from Coreth side or pushes from Subnet-EVM side (pushing requires a special token though).
- I preferred to open PR for single commits to make it easier to review since the context and diffs would be fewer than doing moving diffs in bulk.
- This requires PRs to be merged in squashed commits, otherwise ends up having too much sync PRs.
I'm not saying we should have these, just sharing my previous ideas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't merge it yet.