New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AvaTaxClient class no longer implements Closeable and leaks the threadPool instance #171

Open

rturner-edjuster opened this issue Dec 10, 2024 · 0 comments

rturner-edjuster commented Dec 10, 2024 •

edited

Loading

This pull request removed the close() method #168 which was added in: d72ab15

As a result, the threadPool is never shutdown in a controlled manner, and cannot be managed by the caller / user of the AvaTaxClient class.

I'm not sure if this was an oversight, or an error, or there was some purpose to this removal that is not obvious (or documented in the code).

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment