Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: timeout is optional according to README but required by TypeScript #291

Closed
petrm-integromat opened this issue Nov 13, 2023 · 4 comments
Closed

Regression: timeout is optional according to README but required by TypeScript #291

petrm-integromat opened this issue Nov 13, 2023 · 4 comments

Comments

@petrm-integromat
Copy link

This issue has been fixed once already in 23.8.1 but manifests again in 23.11.0. First reported in #284

When creating new Avatax client instance using new Avatax({...}), I get a TypeScript error that the Property timeout is missing in the passed object but required by the constructor. In documentation it is marked as optional and in code I can see it has a default value. It's just the type that is wrong.
@petrm-integromat
Copy link
Author

Any update on this?

@petrm-integromat
Copy link
Author

@svc-developer please could you take a look at this?

@svc-developer
Copy link
Collaborator

@petrm-integromat Yes will take a look here

@svc-developer
Copy link
Collaborator

24.6.4 addresses this issue, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svc-developer @petrm-integromat