From af30e7303ea6eaf5e631ea7f53303e40ed6f3588 Mon Sep 17 00:00:00 2001 From: Mark Wubben Date: Mon, 1 Nov 2021 14:19:59 +0100 Subject: [PATCH] Remove dead code and obsolete TODOs --- lib/glob-helpers.cjs | 10 +++------- lib/worker/base.js | 2 -- test/snapshot-regenerate-report/test.js | 2 +- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/lib/glob-helpers.cjs b/lib/glob-helpers.cjs index 1d21d7b3c..6e42c550f 100644 --- a/lib/glob-helpers.cjs +++ b/lib/glob-helpers.cjs @@ -97,13 +97,9 @@ function normalizeFileForMatching(cwd, file) { file = slash(file); } - if (!cwd) { // TODO: Ensure tests provide an actual value. - return file; - } - - // TODO: If `file` is outside `cwd` we can't normalize it. Need to figure - // out if that's a real-world scenario, but we may have to ensure the file - // isn't even selected. + // Note that if `file` is outside `cwd` we can't normalize it. If this turns + // out to be a real-world scenario we may have to make changes in calling code + // to make sure the file isn't even selected for matching. if (!file.startsWith(cwd)) { return file; } diff --git a/lib/worker/base.js b/lib/worker/base.js index 7a82f31f3..685f24662 100644 --- a/lib/worker/base.js +++ b/lib/worker/base.js @@ -39,8 +39,6 @@ const run = async options => { process.exit(); // eslint-disable-line unicorn/no-process-exit } - // TODO: Initialize providers here, then pass to lineNumberSelection() so they - // can be used to parse the test file. let checkSelectedByLineNumbers; try { checkSelectedByLineNumbers = lineNumberSelection({ diff --git a/test/snapshot-regenerate-report/test.js b/test/snapshot-regenerate-report/test.js index 6a5b8ad73..e2704984a 100644 --- a/test/snapshot-regenerate-report/test.js +++ b/test/snapshot-regenerate-report/test.js @@ -37,7 +37,7 @@ test('snapshot report can be regenerated from .snap file', async t => { }); // Regenerate report - snapshots.hasChanges = true; // TODO this is a hack + snapshots.hasChanges = true; // Force. snapshots.save(); // Assert that reports match