-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few devops ideas. #374
Comments
|
More on Even without coverage: 20-25 seconds is still a really long time to wait for a failure. Really the best thing to do is learn the When I am hacking on a particular AVA problem, and want to focus on a particular file (let's just say tap -b test/fork.js The |
@jamestalmage, Thanks, thats a good tip to know! But I still think that we don't need to run coverage by default. And I did mean watch for AVA itself. I was just thinking nodemon as a dev dependency. @sindresorhus: Can I go ahead and implement #70? It seems no one has done so. |
👍
I'm not sure I want to deal with that right now. We have enough Babel related overhead and issues. Watching comes with its own headaches. The watch functionality in Node.js core is unreliable and the various watcher libs have edge-cases and downsides, like requiring native addons, which is a no go for us. We've added a lot of features lately, and while I realize it's more fun adding features than fixing bugs, I think we should prioritize the latter right now. My top priority is stabilizing the core and APIs, fixing bugs, and improving performance. |
@sindresorhus: Ok. |
Oh, @sindresorhus: Should I implement a coverage-less test option and a |
Actually, we already have
👍 from me. @jamestalmage ? |
@sindresorhus: How does |
What did you have in mind for a |
@jamestalmage Do you have any preference on having coverage by default when running |
Well, when I have 100% coverage - yeah, I like having it there so I know when I'm introducing new code that isn't covered. Since we are so far off complete coverage, it's really hard to see exactly where you are dropping coverage, I guess we could turn it off. |
@sindresorhus: I have one more larger idea, which I'm not sure if you've ever considered: What about adopting the Angular commit message guidelines? They make it really easy to see what a commit is about, and it allows you to do cool things, like |
@ariporad It's a good idea, but too annoying in reality. Nobody reads the contributing guidelines, so you end up having to tell people (often multiple times) how to format the commit. It creates annoyance for both the contributor and maintainer with minimal gain. I've seen this so many times in the wild. As for That being said, I would be happy to improve on our commit messages, but don't want to enforce it on contributors. |
@sindresorhus: Fair enough. (Although if you ever change your mind, GitCop can do that automagically). |
semantic-release looks awesome and I am personally going to use it in my projects but at this point switching to it would be more pain than it's worth. I think Sindre and the team are going to make sure the version numbers stay sane. Same with enforcing commit message guidelines (even with tools like commitizen). On another note, I admit that whenever I am working on AVA I delete the coverage option in the test script, which means one of these days I am going to forget it to put it back before committing. A regular test script would be great! |
Closing this since the initial issues have been addressed in AVA or are issues with third-party dependencies. Future suggestions on how we can make AVA easier for you to hack on are most welcome though! |
Hi All,
Over the past few days, I've been doing a bit of work on AVA, and I had a few ideas to improve the developer experience, and I wanted to get some feedback on them:
babel.js
is really poorly named. (Personal pet-peeve).npm run test-fast
. Tests are way faster without coverage.Thoughts?
The text was updated successfully, but these errors were encountered: