Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken attach and attach another button for searchable associations #3457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ObiWanKeoni
Copy link

@ObiWanKeoni ObiWanKeoni commented Nov 22, 2024

Description

I think this is all that's necessary to fix the issue linked below. In the AssociationsController, we expect a :turbo_frame param to be passed to the route if we want to rerender the turbo frame instead of closing it. The only bit I'm unclear on is whether we need to have additional special handling for the attach_another button. I figured this was enough.

Fixes #3456

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@github-actions github-actions bot added the Fix label Nov 22, 2024
Copy link

codeclimate bot commented Nov 22, 2024

Code Climate has analyzed commit f6d1328 and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attach and Attach Another action refreshing entire page when searchable: true on has_many field
1 participant