Adding unit tests for AWSMutationDatabaseAdapterTests #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palpatim
previously approved these changes
Dec 4, 2019
| let mockStorageAdapter = MockSQLiteStorageEngineAdapter() | ||
| databaseAdapter = try AWSMutationDatabaseAdapter(storageAdapter: mockStorageAdapter) | ||
| } catch { | ||
| XCTFail("Failed to setup sut") |
There was a problem hiding this comment.
sut is system under test -- i can spell this out, or we can adopt sut
There was a problem hiding this comment.
updated wording to system under test
There was a problem hiding this comment.
Got it. I don't object to it, I just don't use the term regularly, so I didn't recognize it as an acronym without the all-caps spelling :)
wooj2
force-pushed
the
wooj/unittests-OMQ-DADisposition
branch
from
f589fdc to
b238b8a
Compare
wooj2
force-pushed
the
wooj/unittests-OMQ-DADisposition
branch
from
b238b8a to
204c2f3
Compare
palpatim
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.