Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add converter class for model into SQLite and GraphQL components #318

Closed
lawmicha opened this issue Feb 14, 2020 · 1 comment
Closed

Add converter class for model into SQLite and GraphQL components #318

lawmicha opened this issue Feb 14, 2020 · 1 comment
Labels
datastore Issues related to the DataStore category

Comments

@lawmicha
Copy link
Contributor

Synced with Daniel on this, opening issue to refactor some of this conversion logic into some converter class to be used to take model field types and values into SQLite and GraphQL components

Originally posted by @lawmicha in #317
@lawmicha lawmicha changed the title Synced with Daniel on this, opening issue to refactor some of this conversion logic into some converter class to be used to take model field types and values into SQLite and GraphQL components Add converter class for model into SQLite and GraphQL components Feb 14, 2020
@palpatim palpatim added the datastore Issues related to the DataStore category label Feb 14, 2020
@drochetti drochetti mentioned this issue Feb 21, 2020
Merged
drochetti added a commit that referenced this issue Mar 5, 2020
@drochetti
add support for enum and non-model types (#334)
aada5e7 
This fixes problems reported in several issues:  #111 #240 #246 #318 #314

**Notes:**

- added support for SQLite to handle Enums
- added support for SQLite to handle non-model types:
  - custom Codable structs
  - codable arrays
- added tests to make sure the right values are represented as SQLite
bindings
- remove field type string representation
- re-organized schema related files
- add support for Enum and non-model types
- remove commented code
- fix SQLite Int64 precision
- improve documentation and test cases
- better error handling and parameter naming
- addressed PR feedback
- add tests for `AnyEncodable`
- renamed variables for improved readability
- improved error message
- minor naming changes to address PR feedback
- update cocoapods version to be in sync with master

**Tests:**

- added a model that has all types of fields to make it easier to
visualize how data is represented on SQLite

**Pending:**

- More documentation
- GraphQL clenup on API category
@drochetti
Copy link
Contributor

This was mostly done by the PR #334. I'll close this one for now and we can track future improvements of the serialization code in a new ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
datastore Issues related to the DataStore category
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@palpatim @drochetti @lawmicha