feat: Using config to decide base query or delta query #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palpatim
reviewed
Apr 16, 2020
| @@ -54,7 +54,19 @@ final class InitialSyncOperation: AsynchronousOperation { | |||
| } | |||
|
|
|||
| let lastSyncMetadata = getLastSyncMetadata() | |||
| lastSyncTime = lastSyncMetadata?.lastSync | |||
| if let lastSync = lastSyncMetadata?.lastSync { | |||
| let lastSyncDate = Date(timeIntervalSince1970: TimeInterval(lastSync) / 1_000) | |||
There was a problem hiding this comment.
It'd be convenient to extend @drochetti's TimeInterval extension that provides unit-based constructors with a milliseconds so you could just do lastSyncDate = Date(timeIntervalSince1970: TimeInterval.milliseconds(lastSync))
There was a problem hiding this comment.
Hmmm yes, this would be cool. This is not currently in master, so adding a todo, and
| if let lastSync = lastSyncMetadata?.lastSync { | ||
| let lastSyncDate = Date(timeIntervalSince1970: TimeInterval(lastSync) / 1_000) | ||
| let secondsSinceLastSync = (lastSyncDate.timeIntervalSinceNow * -1) | ||
| if secondsSinceLastSync < 0 { |
There was a problem hiding this comment.
Maybe just if lastSyncDate > Date() { ... assume base query ... } ?
There was a problem hiding this comment.
Looked at doing this, but I need secondsSinceLastSync a couple lines down to determine if we should do a delta query.
AmplifyPlugins/DataStore/AWSDataStoreCategoryPlugin/Sync/InitialSync/InitialSyncOperation.swift
Outdated
Show resolved
Hide resolved
AmplifyPlugins/DataStore/AWSDataStoreCategoryPlugin/Sync/InitialSync/InitialSyncOperation.swift
Outdated
Show resolved
Hide resolved
wooj2
force-pushed
the
feature/datastore-config-configPass-sIntv
branch
from
bf03452 to
02a09e7
Compare
wooj2
force-pushed
the
feature/datastore-config-configPass
branch
from
60f222b to
9111186
Compare
wooj2
force-pushed
the
feature/datastore-config-configPass-sIntv
branch
from
02a09e7 to
ea5f132
Compare
wooj2
changed the base branch from
feature/datastore-config-configPass
to
master
palpatim
reviewed
Apr 22, 2020
AmplifyPlugins/DataStore/AWSDataStoreCategoryPlugin/Sync/InitialSync/InitialSyncOperation.swift
Show resolved
Hide resolved
palpatim
approved these changes
Apr 22, 2020
wooj2
force-pushed
the
feature/datastore-config-configPass-sIntv
branch
from
ea5f132 to
52bd777
Compare
wooj2
force-pushed
the
feature/datastore-config-configPass-sIntv
branch
from
52bd777 to
058da3e
Compare
wooj2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.