feat: Datastore use configurable syncMaxRecords and syncPageSize #388
Conversation
| } | ||
|
|
||
| } | ||
|
|
||
| private func updateModelSyncMetadata() { | ||
| private func updateModelSyncMetadata(lastSyncTime: Int?) { |
There was a problem hiding this comment.
I'm not seeing that you are using lastSyncTime in this method?
There was a problem hiding this comment.
On line 182. But hmm.. seems like it's not a good idea to overlap the local function variable lastSyncTime with the instance variable of lastSyncTime.
We were previously always setting the lastSyncTime, which is a bug, because we can have a case where we need to paginate, and when we paginate through a base query, we do not want lastSyncTime to be populated.
But, this has made me think....to make things more clear, it seems like we don't need to keep lastSyncTime as an instance variable.
There was a problem hiding this comment.
Updated to remove instance variable, and will hopefully make things clearer! thanks for the input!
wooj2
force-pushed
the
feature/datastore-config-configPass-sIntv
branch
from
bf03452 to
02a09e7
Compare
wooj2
force-pushed
the
feature/datastore-config-configPass-sIntv-recCount
branch
from
1c915b4 to
90b6d5b
Compare
wooj2
force-pushed
the
feature/datastore-config-configPass-sIntv
branch
from
02a09e7 to
ea5f132
Compare
wooj2
force-pushed
the
feature/datastore-config-configPass-sIntv-recCount
branch
from
90b6d5b to
ef108d0
Compare
AmplifyPlugins/DataStore/AWSDataStoreCategoryPlugin/Sync/InitialSync/InitialSyncOperation.swift
Show resolved
Hide resolved
wooj2
force-pushed
the
feature/datastore-config-configPass-sIntv
branch
2 times, most recently
from
52bd777 to
058da3e
Compare
wooj2
force-pushed
the
feature/datastore-config-configPass-sIntv-recCount
branch
from
ef108d0 to
2bec581
Compare
wooj2
changed the base branch from
feature/datastore-config-configPass-sIntv
to
master
wooj2
changed the title
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.