Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear inProcess state on startup of outgoing mutation queue #391

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

wooj2
Copy link
Contributor

@wooj2 wooj2 commented Apr 17, 2020

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wooj2 wooj2 force-pushed the master-clearStateME branch 2 times, most recently from a1e80f1 to 82c2a84 Compare April 18, 2020 22:48
@wooj2 wooj2 marked this pull request as ready for review April 18, 2020 23:21
@wooj2 wooj2 requested a review from palpatim April 18, 2020 23:21
@wooj2 wooj2 added datastore Issues related to the DataStore category bug Something isn't working labels Apr 18, 2020
Comment on lines +52 to +54
if numMutationEventsUpdated >= mutationEvents.count {
completion()
}
Copy link
Contributor

@drochetti drochetti Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

man, we really need something like Promise.all() in Swift - just ranting, no action needed :D

@wooj2 wooj2 force-pushed the master-clearStateME branch from 82c2a84 to 3436602 Compare April 21, 2020 20:36
@wooj2 wooj2 merged commit 352680b into master Apr 21, 2020
@wooj2 wooj2 deleted the master-clearStateME branch April 22, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working datastore Issues related to the DataStore category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants