Mark outgoing mutation as inProcess if nextEventPromise exists #392
Conversation
wooj2
force-pushed
the
master-clearStateME
branch
2 times, most recently
from
a1e80f1 to
82c2a84
Compare
wooj2
changed the title
wooj2
force-pushed
the
master-clearStateME-markInProg
branch
from
57a0b1f to
ff93b5d
Compare
wooj2
changed the title
wooj2
added
datastore
| storageAdapter.save(mutationEvent, condition: nil) { result in | ||
| var eventToPersist = mutationEvent | ||
| if nextEventPromise != nil { | ||
| eventToPersist.inProcess = true |
There was a problem hiding this comment.
just to clarify if I understand it correctly. This is important in case the mutation event fails so it can be retried later on, is that a correct statement?
There was a problem hiding this comment.
Unfortunately, that is not a correct statement.
To give you a little bit more context, this code should actually be refactored, and technically doesn't belong here. nextEventPromise is assigned if the outgoingMutationQueue asks the AWSMutationDatabaseAdapter for a mutationEvent to be sent out, but the AWSMutationDatabaseAdapter doesn't have an event to offer up. So, when this happens, the AWSMutationDatabaseAdapter saves this promise, and offers up an event when a mutationEvent is ready to be sent out (e.g. customer makes a mutation).
We can sync offline on this, and I can show you a component diagram of various pieces at work here.
wooj2
force-pushed
the
master-clearStateME
branch
from
82c2a84 to
3436602
Compare
wooj2
force-pushed
the
master-clearStateME-markInProg
branch
from
ff93b5d to
ce7f310
Compare
wooj2
force-pushed
the
master-clearStateME-markInProg
branch
from
ce7f310 to
b5ecfe6
Compare
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.