fix(tools): change the tools script to comply with amplify-app changes #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drochetti
commented
May 14, 2020
| trunk: | ||
| https://cdn.cocoapods.org/: |
There was a problem hiding this comment.
@palpatim is this expected/correct?
wooj2
reviewed
May 14, 2020
| @@ -25,7 +25,10 @@ amplifyRegion=$region | |||
| amplifyEnvName=$envName | |||
|
|
|||
| if $amplifyModelgen; then | |||
There was a problem hiding this comment.
not familiar with this syntax, i would have expected to check if amplifyModelgen is not set by using:
if [[ ! -z $amplifyModelgen ]]; then
There was a problem hiding this comment.
I'm not familiar either tbh
| @@ -24,7 +24,7 @@ DEPENDENCIES: | |||
| - SwiftLint | |||
|
|
|||
| SPEC REPOS: | |||
| trunk: | |||
| https://cdn.cocoapods.org/: | |||
There was a problem hiding this comment.
per tim's comment above -- same with this.. is this expected? i would have probably reverted this change.
There was a problem hiding this comment.
me too, but why did my cocoapods make that change? If that's not supposed to happen then I'm very confused 😕
wooj2
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See aws-amplify/amplify-cli#4268 for details
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.