feat(Auth): Implementation of getCurrentUser api #455
Conversation
| @@ -16,13 +16,14 @@ class AuthenticationProviderAdapter: AuthenticationProviderBehavior { | |||
| self.awsMobileClient = awsMobileClient | |||
| } | |||
|
|
|||
| func signInUsername() -> Result<String, AuthError> { | |||
| func currentUser() -> AuthUser? { | |||
There was a problem hiding this comment.
rename to getCurrentUser, or make this a property.
| /// Value maps to the username of a user in AWS Cognito User Pool. This value is set by AWS Cognito and not by the | ||
| /// user and does not always map with the username used to signIn. |
There was a problem hiding this comment.
As noted offline, we need to figure out this behavior.
There was a problem hiding this comment.
Keeping this for now as discussed
royjit
force-pushed
the
royjit/AuthCurrentUser
branch
from
cbb4aff to
c7bd293
Compare
There was a problem hiding this comment.
Approved w/comments, but in general, we need to pay better attention to our naming, even internally. If a method is returning a value, name it 'get' (for retrievals) or 'make' (for creation). If a value can be reasonably modeled as a property (synchronous, no throwing conditions, no parameters required), favor properties rather than getter methods.
| @@ -107,6 +107,10 @@ class AWSMobileClientAdapter: AWSMobileClientBehavior { | |||
| return awsMobileClient.username | |||
| } | |||
|
|
|||
| func userSub() -> String? { | |||
There was a problem hiding this comment.
Make this getUserSub() or a property
| @@ -52,6 +52,8 @@ protocol AWSMobileClientBehavior { | |||
|
|
|||
| func username() -> String? | |||
|
|
|||
| func userSub() -> String? | |||
There was a problem hiding this comment.
make this getUserSub() or a userSub property.
| @@ -52,6 +52,8 @@ protocol AWSMobileClientBehavior { | |||
|
|
|||
| func username() -> String? | |||
There was a problem hiding this comment.
Make this getUsername() or a username property
royjit
force-pushed
the
royjit/AuthCurrentUser
branch
2 times, most recently
from
be2d637 to
1a50870
Compare
royjit
force-pushed
the
royjit/AuthCurrentUser
branch
from
1a50870 to
6e09cc4
Compare
Description of changes:
This PR is dependent on userSub api in AWSMobileClient - aws-amplify/aws-sdk-ios#2599
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.