Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rest API with UserPool Integration tests #312

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Feb 10, 2020

This adds integration tests around using APIGateway with Cognito User Pool token authentication. Updated some error handling logic to accurately bubble up the error for "User is not authenticated and tries to make a call against the API", so is reflected in the test.

Currently Amplify-CLI experience does not support creating REST API with cognito use pool authorizier, experience and feature request documented here: aws-amplify/amplify-category-api#345

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha requested a review from palpatim February 12, 2020 21:25
@lawmicha lawmicha marked this pull request as ready for review February 12, 2020 21:25
@@ -1,7 +1,7 @@
platform :ios, '11.0'
use_frameworks!

AWS_SDK_VERSION = "2.12.2"
AWS_SDK_VERSION = "2.12.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're on .7 now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will chat with @iartemiev offline about this, most places are 2.12.6, and a few like analytics is 2.12.2, so possibly there is a script that needs to be updated to catch all podfiles.

@lawmicha lawmicha merged commit c6b902b into master Feb 12, 2020
@lawmicha lawmicha deleted the rest-userpool branch April 27, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants