Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datastore delete model type with local predciate API w/out predicate on sync #346

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Datastore delete model type with local predciate API w/out predicate on sync #346

merged 1 commit into from
Mar 11, 2020

Conversation

wooj2
Copy link
Contributor

@wooj2 wooj2 commented Mar 6, 2020

This code adds the following concepts:

  • sql transaction interface to the storageAdapter
  • QueryPredicateConstant.all to query for all items
  • New delete(type, predicate) interface for storageEngine/ModelStroageBehavior
  • Implementation of transaction-based delete Model.Type w/ predicate
  • Submission of individual deleted modelIds to be submitted to the sync engine, but without the predicate. Deferring submitting the predicate until we can refactor the MutationEvent to two separate classes -- one to notify customers, and one to submit into the SyncEngine

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wooj2 wooj2 requested a review from drochetti March 6, 2020 06:45
@drochetti drochetti added the datastore Issues related to the DataStore category label Mar 11, 2020
@wooj2 wooj2 force-pushed the master-deletePredicate branch from 913c059 to 3f38952 Compare March 11, 2020 22:58
@wooj2 wooj2 merged commit 1027154 into master Mar 11, 2020
@wooj2 wooj2 deleted the master-deletePredicate branch April 8, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawmicha lawmicha lawmicha left review comments

@drochetti drochetti drochetti approved these changes

Assignees
No one assigned
Labels
datastore Issues related to the DataStore category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wooj2 @drochetti @lawmicha