fix(api): incorrect selection set for optional associated field #509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#483
Description of changes:
This PR fixes a problem with the selection set that is generated for a Model containing a connection to another Model. Take this for example
translates to "A Post has an optional association to the User"
.belongsTo(post.user, is: .optional, ofType: User.self, targetName: "postUserId"),
The original code checked for required associations
Consider a case where we retrieve the Post and the User does not exist on the Post. The selection set's intent is to retrieve that data in the response, and no User data is returned, thus nothing gets deserialized into the Post's User field.
This PR adds the following schema to test building a GraphQLRequest
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.