fix(tools): require min version or use @latest #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooj2
commented
Jun 3, 2020
palpatim
reviewed
Jun 3, 2020
palpatim
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In attempts of addressing:
#502
If customers have an older version of amplify-app installed on their machines, we will exec the command:
Otherwise, we will execute:
Forcing latest did not seem like the right thing to do. Also, when running npx, there isn't a good way of status-ing where the command (amplify-app) is being pulled from ( a local repo, or... online. etc..)
In addition to checking the version of
amplify-app, I extended this to check the version of amplify-cli per the request of @drochetti. We will fail a build if customers do not have a minimum version required foramplify-cli. Upon failing a build, they will be greeted with this message in Xcode:Fully open to suggestions on this one!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.