fix(DataStore): Support all Temporal types in predicates #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drochetti
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amplify GraphQL Predicates should support all Temporal types, but only Date was previously supported. This change also reformats the
graphQLValueto use a more Swiftyswitchstatement instead of multiple if/thens.Note: The assertions in the new unit tests aren't terribly meaningful, but by exercising the code, we can ensure we won't hit a precondition failure due to an unsupported type.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.