fix(build): podspec source version tag and url #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palpatim
approved these changes
Jun 11, 2020
lawmicha
reviewed
Jun 16, 2020
dependencies.rb
Outdated
|
|
||
| # GitHub tag name for Amplify releases | ||
| def release_tag | ||
| "v#{$AMPLIFY_VERSION}" |
There was a problem hiding this comment.
Yes, the tag name should start with v
lawmicha
approved these changes
Jun 16, 2020
royjit
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
dependencies.rbwhich contains common dependency configuration for all modulesPodfile.lockto standardize the dependencies across environments for all modules (previously it was only for Core, for unknown reasons)$) so Cocoapods stop emitting warnings for redefined valuesps:
Podfile.lockfiles represent most of the diff, it is safe to ignore them during reviewBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.