Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the developer menu launch ready #844

Merged
merged 12 commits into from
Oct 22, 2020
Merged

make the developer menu launch ready #844

merged 12 commits into from
Oct 22, 2020

Conversation

drochetti
Copy link
Contributor

@drochetti drochetti commented Oct 21, 2020

Note: This PR has the goal to merge all the work done for the dev menu into main. All the commit here were already reviewed and approved, I just tested it and resolved the merge conflicts.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@drochetti drochetti added the work in progress Issues was triaged and investigation done label Oct 21, 2020
@drochetti drochetti requested review from royjit and wooj2 October 22, 2020 19:16
@drochetti drochetti marked this pull request as ready for review October 22, 2020 19:16
@drochetti drochetti added this to the 1.4.0 milestone Oct 22, 2020
Copy link
Contributor

@royjit royjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drochetti drochetti merged commit 4dd436c into main Oct 22, 2020
@drochetti drochetti deleted the dev-menu branch October 22, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work in progress Issues was triaged and investigation done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants