Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AWSPluginsCore] Investigate removing GraphQLDocumentValueRepresentable #370

Closed
lawmicha opened this issue Apr 2, 2020 · 0 comments
Closed

[AWSPluginsCore] Investigate removing GraphQLDocumentValueRepresentable #370

lawmicha opened this issue Apr 2, 2020 · 0 comments
Labels
datastore Issues related to the DataStore category feature-request Request a new feature

Comments

@lawmicha
Copy link
Contributor

lawmicha commented Apr 2, 2020

Describe the bug
The value placed in the GraphQL Document variables can be updated to Persistable.

reference:
GraphQLDocumentValueRepresentable's graphQLDocumentValue is never used
https://github.com/aws-amplify/amplify-ios/blob/ad9477321cf26a90b9fd0add29a53533eb2f00d3/AmplifyPlugins/Core/AWSPluginsCore/Model/Support/GraphQLDocumentnputValue.swift#L23

Value is accessed here:
https://github.com/aws-amplify/amplify-ios/blob/master/AmplifyPlugins/Core/AWSPluginsCore/Model/GraphQLDocument/SingleDirectiveGraphQLDocument.swift#L72

QueryPredicate.toGraphQLFilter uses Persistable.toGraphQLValue of type Any
@lawmicha lawmicha mentioned this issue Apr 2, 2020
Merged
@palpatim palpatim added the datastore Issues related to the DataStore category label Apr 3, 2020
@lawmicha lawmicha added feature-request Request a new feature and removed enhancement labels Jul 8, 2021
@lawmicha lawmicha added the p3 label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
datastore Issues related to the DataStore category feature-request Request a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@palpatim @drochetti @lawmicha @thisisabhash