fix(IoT): Fixing a intermittent crash when deallocating AWSIoTStreamThread
#5269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We're currently calling
[self cleanUp]
ondealloc
, which basically invalidates the timer and checks if it should close the streams and invoke a callback.Generally, it's not recommended to rely on the
dealloc
method to perform expensive operations.cleanUp
is already always being called when the thread is cancelled, so calling it again when the thread is deallocated is not only redundant, but might be the cause of the linked crash due to attempting to access other near-deallocated objects and/or properties.Check points:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.