Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent @types/prettier release breaks TypeScript build of TenantPipeline #27

Closed
chalcrow opened this issue May 27, 2022 · 3 comments
Closed

Comments

@chalcrow
Copy link

chalcrow commented May 27, 2022

The TenantPipeline currently fails to build (during initial creation via the main ./deployment.sh) unless the TypeScript package version is updated in the package.json for the pipeline. Apparently this is due to a breaking change in a recent @types/prettier package release

I fixed the issue by updating to "typescript": "^4.2.0" in the package.json for the TenantPipeline

A description of the issue including the error encountered is at - DefinitelyTyped/DefinitelyTyped#60314

@suhussai
Copy link
Contributor

Hi @chalcrow , thanks for reporting this issue and providing the link. This error is also reported in the CDK public repo. You can find it here: aws/aws-cdk#20319

The solution mentioned there is to pin the @types/prettier package to 2.6.0 in the devDependencies section in the package.json file, which is the fix included in this open PR #25. If, for some reason, that does not work for you, please let us know and we will take another look.

We are reviewing that PR and plan to merge it into the main branch soon.

@suhussai
Copy link
Contributor

#25 has been merged. Can you try updating your repo and re-running the deployment.sh script?

@ujwalbukka
Copy link
Contributor

Closing this issue. Please reopen if you still have any issues/questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants