feat!(guest-webapp-sample):Change launch configurations to launch tem… #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! I will review in this week. |
konokenj
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
LGTM. This is not a breaking change, because:
- Users can replace these EC2 instances safely because they are stateless.
- BLEA's versioning is applied to baseline version. Guest sample apps are just sample code, therefore breaking changes are permitted (but it should not be often).
- We know this policy should be documented
konokenj
force-pushed
the
feature/add-ec2-launch-template
branch
from
597adc8 to
d7b5cca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #60
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT No Attribution (MIT-0).