feat(base-ct-audit)!: delete base-ct-audit #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konokenj
force-pushed
the
feature/v3-base-ct-audit-delete
branch
from
6c2b72d to
cf50be3
Compare
ohmurayu
approved these changes
Mar 16, 2023
konokenj
added a commit
that referenced
this pull request
Apr 20, 2023
* feat(base-ct-audit)!: delete base-ct-audit (#221) Delete Audit account baseline. This is discussed in #237. * feat(base-standalone)!: compose into 1 stack, and use parameter.ts (#161) * refactor(base-standalone): compose into 1 stack and use parameter.ts * feat(base-standalone): refactor file and construct names * build: fix eslint fails on jest.config.js * fix(base-standalone): remove chatbot params * test(base-standalone): fix snapshot test * Revert "build: fix eslint fails on jest.config.js" This reverts commit 18f4275. * build(base-standalone): remove unused settings from package.json * update package-lock.json * feat(base-ct-guest)!: compose into 1 stack, and use parameter.ts (#220) * feat(base-ct-guest)!: compose into 1 stack and use parameter.ts * feat(base-ct-guest)!: rename usecase * build(base-ct-guest): remove lint, format npm tasks * test(base-ct-guest): fix snapshot test * feat(base-ct-guest): deploy baseline via Service Catalog / AFC * remove product-stack-snapshots * add CDK Pipelines into blea-base-ct-guest --------- Co-authored-by: Yukitaka Ohmura <[email protected]> * refactor(guest-apiapp-sample): merge into single stack and change method to access parameter (#240) * Merge multiple stacks to one stack. * Merge two language (Python, Node.js) sample applications into single application. * Change method to access parameters to use parameter.ts * refactor(guest-webapp-sample)!: split into 2 usecases, and decrease number of stacks (#239) * refactor(guest-webapp-sample)!: split into 2 usecases, and decrease number of stacks * delete .gitignore from ec2app-sample * Update package-lock.json --------- Co-authored-by: Yukitaka Ohmura <[email protected]> * refactor(blea-base-ct-guest): Separate deploy parameter from pipeline * doc: Update Japanese docs to align v3 procedure * refactor: renew deprecated method and class on CloudWatch * fix: delete unnecessary information (#245) * refactor: rename Construct IDs and variable names * refactor: set different names to ct/standalone * refactor: rename packages * test: add missing snapshot tests for gov-base-ct and fix formats * refactor: remove "security" prefix * build: refactor npm packages and build scripts * ci: remove product-stack-snapshots generated by test * ci: fix escape * refactor: fix ecs-app class names * fix: pass env parameter to stacks * test: update snapshots * fix: specify env * build: remove parameter.js when clean, and update snapshots * feat: re-add Chatbot to gov-base when deploy via CLI * test: fix tests * feat(ecs-app): deploy without custom domain * refactor: rename Construct IDs and variable names for consistent use in this project (#286) * refactor: rename Construct IDs and variable names * refactor: set different names to ct/standalone * refactor: rename packages * test: add missing snapshot tests for gov-base-ct and fix formats * refactor: remove "security" prefix * build: refactor npm packages and build scripts * ci: remove product-stack-snapshots generated by test * ci: fix escape * refactor: fix ecs-app class names * fix: pass env parameter to stacks * test: update snapshots * fix: specify env * build: remove parameter.js when clean, and update snapshots --------- Co-authored-by: Yukitaka Ohmura <[email protected]> * docs: restore codes to use custom domain on CloudFront as a comment * fix(gov-base-ct, gov-base-standalone): adopt s3's new bucket default security policy (#296) * fix(gov-base-ct, gov-base-standalone): adopt s3's new bucket default security policy * doc: Update English docs to align v3 (#297) * docs: add versioning policy and some fixes * build: remove cdk --------- Co-authored-by: Kenji Kono <[email protected]> Co-authored-by: Kenji Kono <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delte base-ct-audit usecase because this usecase manages only an AWS Chatbot channel. Also, AWS Chatbot requires manual configuration for workspace via AWS Management Console before starting using. So it is reasonable for users to manage AWS Chatbot via AWS Management Console.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT No Attribution (MIT-0).