Hotfix: bucket-enforce-ssl #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watany-dev
force-pushed
the
hotfix/bucket-enforce-ssl
branch
from
a7e24b2 to
5ea4346
Compare
watany-dev
force-pushed
the
hotfix/bucket-enforce-ssl
branch
from
5ea4346 to
2f17ab0
Compare
|
Thank you for contribution. We'll check your PR. |
|
I have tested and looks good. I'll merge it. |
terayas
pushed a commit
to terayas/baseline-environment-on-aws
that referenced
this pull request
Jun 13, 2022
* refactor "Force SSL settings" in the L2 Constructs property * fix: missing SSL setting leaked in the bucket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some buckets with and without "enforceSSL = true". I also found places where L1 was used without using L2Construct, but these seemed to be inevitable, so I fixed them as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT No Attribution (MIT-0).