Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing functionality for setting different aws partitions #3

Open
tielong opened this issue Aug 17, 2021 · 0 comments
Open

Missing functionality for setting different aws partitions #3

tielong opened this issue Aug 17, 2021 · 0 comments

Comments

@tielong
Copy link

tielong commented Aug 17, 2021

Hello,

First of all thanks for creating this great sample! It is super helpful and saved us a lot of development efforts.

I noticed that currently the sample doesn't allow setting aws partition as an override parameter. I am based on China and most of our resources are located within aws-cn instead of aws.

I was able to manually update the template file as well as the lambda function to make our case work, but I could see how adding the ability to override partition could benefit future users, especially considering we have at least 3 partitions for AWS now: aws, aws-cn, aws-us-gov, and that list might grow in the future. (Similar to "TargeRoleName", "TargetRegion" maybe we can have "TargetPartition")

Thanks a lot and thanks again for this awesome sample!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant