Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unusable user_input.yaml #17

Closed
Maniarr opened this issue Jun 10, 2020 · 2 comments
Closed

Unusable user_input.yaml #17

Maniarr opened this issue Jun 10, 2020 · 2 comments

Comments

@Maniarr
Copy link

Maniarr commented Jun 10, 2020

Hello,

When i use user_input.yaml in add-on to templatize some files, values are not correctly replaced by the find_replace.py script.

Example, for the variable named key with value value_of_key_variable.

In template, the string {{ key }} will be replaced by "value_of_key_variable" instead of "value_of_key_variable".

A small modification of the script introduce this error in v1.1.0.

v1.0.0:

# bin/codebuild_scripts/find_replace.py:33
...
        j2env = jinja2.Environment(loader=j2loader)
...

v1.1.0:

# bin/codebuild_scripts/find_replace.py:35
...
        j2env = Environment(loader=j2loader, autoescape=True)  # Compliant
...

Can you reverse it ?

@groverlalit
Copy link
Member

Thanks @Maniarr for raising this issue. We have added this to our backlog and plan to publish the requested change in the next release.

@rakshb
Copy link

rakshb commented Jul 8, 2020

Hello @Maniarr . We have fixed this issue in CFCT V1.2

@leavertj leavertj closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants