Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed Bucket Name Patterns #1

Closed
isTravis opened this issue Sep 5, 2017 · 5 comments
Closed

Allowed Bucket Name Patterns #1

isTravis opened this issue Sep 5, 2017 · 5 comments

Comments

@isTravis
Copy link

isTravis commented Sep 5, 2017

The allowed pattern does not allow periods to exist in bucket names - even though periods are valid in S3 bucket creation. Perhaps this could be changed to [a-zA-Z][a-zA-Z0-9-.]* to allow periods.

https://github.com/awslabs/serverless-image-handler/blob/master/deployment/serverless-image-handler.template#L12

@isTravis isTravis changed the title Allowed Allowed Bucket Name Patterns Sep 5, 2017
@onassar
Copy link

onassar commented Sep 22, 2017

I ran into this too. Needed to remove the AllowedPattern to make this work.

@stevemorad
Copy link
Contributor

Thanks for the comment. I incorporated support for periods into the template and this should get pushed out in the next update.

@stevemorad
Copy link
Contributor

Would you test out this template, and verify that the new constraint works for your buckets?
https://s3.amazonaws.com/solutions-test-reference/serverless-image-handler/latest/serverless-image-handler.template

@onassar
Copy link

onassar commented Sep 30, 2017

Just tested, and there were no problems specifying a bucket that had periods in it.

@stevemorad
Copy link
Contributor

Template updated. Closing ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants