-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working #119
Comments
Hi @cjbAus - If I understand your question correctly, you are looking for a way to access images using thumbor style and not the "sharp" way. I tried the following for my distro and its working ( I too was using thumbor style earlier) All the thumbor filters ( the ones I need ) were working ( of course fit-in isn't proper and requires changes to their codebase ). Does this help ? |
The core issue we found is the thumbor url style only work if you have all
the images are in the base of the bucket. If you use a image which is in a
subfolder ie key would be live/thumbnail.jpg the service no longer works.
Looking at the code base this is due to the function used to get the key is
only getting the last bit of the uri.
We downloaded the git repo and fixed the code but when we try to deploy it
always fails as it says it cannot find the bucket so there seems to be an
issue with the deploy script. We tried a few time to adjust this but was
still having issues so we just took our code fix and created a separate
lambda function which we use to convert the url to sharp then pass it to
the aws lambda script. This works a treat but does create extra lambda
calls and some cost increase.
We hope at some point the key issue will be fixed in the core code base. If
you like we can send you a sample of what we have done if that helps. It
is only a couple of lines of changes to the thumbor mapping js and changing
the method used to get key in the image handler js if thumbor style uri is
being used.
Cheers
@cjbAus
|
Actually, I am just a user of this product and was trying to help out ( came here searching for rewrite urls issue ). For your issue, seems like there is another bug: #112 |
Hey @cjbAus - Thanks for bringing this issue to our attention! We're in the process of reviewing #130 which should address your issue of sourcing images from S3 subdirectories. We've also reviewed and updated the documentation for this solution, making several improvements, and should have that rolled out in the upcoming week! |
We have updated our solution, and I believe your issue has been fixed. If you still see the issue with the latest version (v4.2), please feel free to reopen the issue. You can refer to the recent changes here |
The codebase and documentation seems to be a little floored. When you build from the repo it will not install and fails at the s3 bucket stage every time.
If you install using the AWS hosted template this will work but you can only get it to work if you base64 encode or store every image in the root of the bucket. base64 encoding data to get an image resized is not practical and not how pretty most people will want to use a on the fly image service.
The url based (Thumbor style paths) are key to getting the most value out of this type of service but you need to be able use a object which is not in the base of the bucket.
When do you think the next release will be with a fix to the image paths? or improved documentation and steps to fix the s3 bucket issue when using the repo
The text was updated successfully, but these errors were encountered: