Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working #119

Closed
cjbAus opened this issue Jul 8, 2019 · 5 comments
Closed

Not working #119

cjbAus opened this issue Jul 8, 2019 · 5 comments

Comments

@cjbAus
Copy link

cjbAus commented Jul 8, 2019

The codebase and documentation seems to be a little floored. When you build from the repo it will not install and fails at the s3 bucket stage every time.

If you install using the AWS hosted template this will work but you can only get it to work if you base64 encode or store every image in the root of the bucket. base64 encoding data to get an image resized is not practical and not how pretty most people will want to use a on the fly image service.

The url based (Thumbor style paths) are key to getting the most value out of this type of service but you need to be able use a object which is not in the base of the bucket.

When do you think the next release will be with a fix to the image paths? or improved documentation and steps to fix the s3 bucket issue when using the repo

@mandys
Copy link

mandys commented Jul 15, 2019

Hi @cjbAus - If I understand your question correctly, you are looking for a way to access images using thumbor style and not the "sharp" way.

I tried the following for my distro and its working ( I too was using thumbor style earlier)
https://<your_cf_url>.cloudfront.net/fit-in/500x500/filters:quality(90):fill(fff)/my_source.jpg

All the thumbor filters ( the ones I need ) were working ( of course fit-in isn't proper and requires changes to their codebase ).

Does this help ?

@cjbAus
Copy link
Author

cjbAus commented Jul 15, 2019 via email

@mandys
Copy link

mandys commented Jul 15, 2019

Actually, I am just a user of this product and was trying to help out ( came here searching for rewrite urls issue ). For your issue, seems like there is another bug: #112

@hayesry
Copy link
Member

hayesry commented Aug 4, 2019

Hey @cjbAus - Thanks for bringing this issue to our attention! We're in the process of reviewing #130 which should address your issue of sourcing images from S3 subdirectories. We've also reviewed and updated the documentation for this solution, making several improvements, and should have that rolled out in the upcoming week!

@beomseoklee
Copy link
Member

We have updated our solution, and I believe your issue has been fixed. If you still see the issue with the latest version (v4.2), please feel free to reopen the issue.

You can refer to the recent changes here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants