Quality parameter not working

[khawerrind]

I am trying to pass in the quality parameter for the jpeg image. However quality does not have any effect on the size of the image.

const imageRequest = JSON.stringify({
    bucket: "----",
    key: "----",
    edits: {
    	resize: {
            width: 300,
            height: 300,
            fit: 'inside'
    	}
    },
    jpeg: { quality: 70 }
});

I tried to change the quality to 40 but the size of the image is same as with quality 60 or even if there is no quality parameter. Am i missing something?

[leviwilson]

@khawerrind in the image-request.js it isn't passed through it doesn't look like: https://github.com/awslabs/serverless-image-handler/blob/master/source/image-handler/image-request.js#L25-L29

Just a guess, but you might pass the jpeg key in the edits hash for it to work https://github.com/awslabs/serverless-image-handler/blob/02e811850155ccb398c8f4b6c5fdbbe1481f78b4/source/image-handler/thumbor-mapping.js#L151-L161

[khawerrind]

@leviwilson this still does not work. I think this is just for thumbor but i am not using thumbor style mapping.

[leviwilson]

@khawerrind I think what you want is #116

That allows for the output option to be honored where you can additionally specify the quality I think. That currently isn't being honored, but if you pull that branch that I have it should work for you.

[hayesry]

All, FYSA we've added @leviwilson's PR (#117) as referenced in #116 to our review board and hope to have it tested and rolled out in the next minor release. Thanks!

[rromanchuk]

It would be nice to also add output settings to the demo. I know this wraps Sharp but I'm not confident how I interface with it from my request body, and what is/isn't supported. I'm just starting to dig in the source now and I noticed new concepts like requestType and outputFormat. Does this mean i can theoretically pass in an options hash for even something like this? https://sharp.pixelplumbing.com/en/stable/api-output/#heif

https://github.com/awslabs/serverless-image-handler/blob/9ccdb7180c7881eb78c220f3958b671d968c16dd/source/image-handler/test/test-image-handler.js#L64

const request = {
                requestType: "default",
                bucket: "sample-bucket",
                key: "sample-image-001.jpg",
                outputFormat: "png",
                edits: {
                    grayscale: true,
                    flip: true
                },
                originalImage: new Buffer('iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mP8z8BQDwAEhQGAhKmMIQAAAABJRU5ErkJggg==', 'base64')
            }

[beomseoklee]

We have updated our solution, and I believe your issue has been fixed. If you still see the issue with the latest version (v4.2), please feel free to reopen the issue.

You can refer to the recent changes here