-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Default Image Fallback #137
Comments
Hi, might be unrelated, but were you able to check the error associated with {} returns? for us, it was because of I pushed a PR which addresses this but it requires a node_modules rebuild as a more recent version of Sharp is needed. -> #130 |
Hey @mberneis - thanks for your feature request. I've gone ahead and added that to our backlog for the solution and will begin looking into it! @rpong - sorry you've been having trouble using images from Samsung devices with this solution. I've made a note of this as well and will look into the PR you provided at #130. Thanks! |
Hi @hayesry I was looking for something similiar to @mberneis request, but in my case was just to have a "default image" when a 404 is produced from the S3 (when the image does not exist in the S3 bucket). Is there any way I can setup this (default image) without making any change in the Lamba code and/or the infrastructure? Thanks a lot! |
Hey @rodrigofirpo For simply returning a default image whenever one can't be found in the S3 bucket, I would use the getOriginalImage() method at |
Thanks @hayesry, We will go this way! If we see that our solution is clean (from the programming POV) and could be helpful for other users we will create a Pull Request, perhaps other users could take advantage from this. Best! |
Hello, I also want to do the same as you described above @rodrigofirpo, with a fallback image. Have you made a working solution? Is it something that you could share? |
Hi all, If anyone is still interested in the default image fallback, what kind of fallback image would be good for everyone? Please let us know so that we can think about this one. |
@4ice sorry I didn't answer before. At the moment we have this functionality in stand-by (for other reasons) However, even if @beomseoklee solution could help a lot of people (thanks for that), that is not our case, we need to set our company fallback image. |
Maybe we can make this fallback image a specifiable "parameter"? |
Yes still interested in a solution / passing a default image url as an optional parameter would be great. If data url would be supported |
Thanks for waiting. We've released v5.1.0, and the version contains the default fallback image feature so that you can define your own image to return when any error happens. |
It would be great if one could provide a default fallback image URL in case the image processing is not able to handle the incoming image.
Or at least supply a 1 pixel GIF instead of
{}
Invalid incoming images cause other things to fail in my pipeline and it would be nice if that could be caught earlier
The text was updated successfully, but these errors were encountered: