-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating from Thumbor to SharpJS #169
Comments
Hi @onassar, The list of supported Thumbor filters is available on the implementation guide: https://s3.amazonaws.com/solutions-reference/serverless-image-handler/latest/serverless-image-handler.pdf
|
Thanks; I took a look at that but didn't see the same transformations (eg. specifying just a width/height without a specific thing like Let me take a closer look and re-open this ticket if I can't find it. |
Hi - Here is a sample URL using the This was created using the following run in your console:
This will copy the above URL to your clipboard, which works fine. However, when I then follow the Appendix, I should be able to request the same (type of) image using the following URL: The error upon requesting that URL is:
The image is a valid type. Notice that the CDN hostname is the same, the filter is the same, and the object key is the same. From the guide, it reads:
Would appreciate some guidance. |
Hi @onassar, It looks like the image-request function expects the key name to contain the file extension: Would it be possible to check if problem still happens if the extension is present? For example: {
bucket: 'my-bucket',
key: 'file.jpg',
edits: {
grayscale: true
}
} |
So the problem is that the object doesn't actually have a filename extension. That's by design. When I append a filename extension that matches the Content Type of the file, the URL becomes: But then the error (quite naturally) becomes:
It seems like the mistake here is the presumption that an object always has a file extension. |
Happy Holidays! Also: bump ;-) |
Hi @onassar, As mentioned before, this is expected behavior of the solution at this time, but we'll keep this issue open and we will address it if there's enough demand for it. For the next release, we're focusing on integrating the open PRs (https://github.com/awslabs/serverless-image-handler/pulls). |
Okay thanks for the response. I would imagine it's not uncommon for people to omit file extensions, but I can't be sure. |
I know there are linked issues, but just for prosperity I would like to highlight I have this problem here: We do not use file extensions in our S3 bucket. |
We've added limited support for files without extensions in v5.2.0. Any image filters that use Amazon Rekognition (content moderation and smart cropping) will not work with files that do not have an extension. |
Hi there -
Going through the flow to update my CloudFormation stack, and wondering if there's any good documentation on what's supported by SharpJS relative to Thumbor.
I'm finding it a tad confusing as to how to actually rewrite URLs, and what parts are supported (eg.
full-fit-in
, quality filters etc).Is there any solid tutorials, documentation or examples I could follow?
The text was updated successfully, but these errors were encountered: