Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security(Tampering encoding) in Old and New URLs #203

Closed
atrope opened this issue Apr 7, 2020 · 2 comments
Closed

Security(Tampering encoding) in Old and New URLs #203

atrope opened this issue Apr 7, 2020 · 2 comments

Comments

@atrope
Copy link

atrope commented Apr 7, 2020

Hi All,
I've implemented old thumbor feature of having a hash on each url.
It works on old urls (thumbor format) and also new urls base64 encoded(I've added the parameter "hash" to the object).
I Got the base function from the PR here: #111 (thanks to @soupy1976)
I've implemented in a rush, so it is not ready for PR yet but I was thinking if there is a need to make a proper PR or is it a thing that not all people need?
The way we have, We only check for the key if there is the SECURITY_KEY env variable, giving the user the choice.

Let me know if a PR is needed.

Thanks

@piecedata
Copy link

Hi @atrope, it will be cool if you can share this. Thanks

@beomseoklee
Copy link
Member

Thanks for your inputs and waiting for the response. We've added the feature to meet this request in v5.1.0, so please take a look at the latest one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants