Thumbor paths broken if they include "-" and "100x100"

[Furytron]

Hi All,

Hope someone can help me with this one. I've got v4.2 deployed and we have stumbled onto an odd issue. I've looked at the open and closed tickets and could only see 163 which might be related but is not the same.

When an S3 key has a hypen "-" and is then followed by two numbers that are separated by (lowercase) "x" either in the path or the filename the image is not returned to you when you go to the cloudfront URL.

Some examples of broken URLs that only return an empty object: {} with a 200 response.

• https://test.cloudfront.net/test/test-100x100.jpg
• https://test.cloudfront.net/test/test-100x100x.jpg
• https://test.cloudfront.net/test/test--100x100.jpg

To narrow down the scope of the problem, I tried the following URLs with altered but similar filenames and they all work correctly. Images are returned.

• https://test.cloudfront.net/test/test-100y100.jpg
• https://test.cloudfront.net/test/test100-100.jpg
• https://test.cloudfront.net/test/test100x100.jpg
• https://test.cloudfront.net/test/test100y100.jpg
• https://test.cloudfront.net/test/-test100x100.jpg
• https://test.cloudfront.net/test/test100100-.jpg
• https://test.cloudfront.net/test/test100x100-.jpg
• https://test.cloudfront.net/test/test-asd100x100x.jpg
• https://test.cloudfront.net/test/test-100X100.jpg (Note the uppercase x)

The same is happening for paths in the S3 key, but you get a different response (404) from the browser. For example a broken URL with the values in the path:

• https://test.cloudfront.net/test-100x100/test/test.jpg

This time you get the following returned:
status 404 code "NoSuchKey" message "The specified key does not exist."

I think the issue is being caused by the confusion with the "fit-in" filter: /fit-in/800x1000/ but that is just a guess.

For the path issue, it might be related to the code in image-request.js.

A code test using that function shows that the URL paths are broken: https://jsfiddle.net/Furytron/bqjf07zu/2/ when they include those characters, in that order. But this code does not break for the filename. So there may be two issues occurring here.

Any help would be appreciated on this.

[shortdoormedia]

I am not sure if it is the exact same issue but i was having trouble with file names that included any dimensions. See my post here: #176 (comment)

I had to add a lambda function in order to convert the uri requests into something that was consumable.

[Furytron]

Thanks @shortdoormedia for the reply and link to your issue. I knew there had to have been an issue logged like this. I just missed it.

So it appears from that thread that the issue was only partially fixed.

I'm not 100% sure I understand that comment you have linked from @beomseoklee, he appears to say that its not supported having files with those names.

In my case, the image in the S3 key: https://test.cloudfront.net/test/test-100x100.jpg would have already been a resized image from our application and the "-100x100" automatically gets appended to the name to differentiate it from the original.

I will have a look at your solution for the lambda, thanks again for posting!

[shortdoormedia]

In your case it's trying to grab an image dynamically sized at: -100x100. The function/bug only grabs the first instance of dimensions from a uri request string.

You need to re-write your request to:
https://test.cloudfront.net/fit-in/100x100/test/test-100x100.jpg

[Furytron]

@shortdoormedia

Just to note that I am not actually applying any filters when I request
https://test.cloudfront.net/test/test-100x100.jpg. I haven't even applied filters yet. The "-100x100" is just in the name of the file, I don't want anything to be resized or changed. So the URL doesn't return the image since it has that string in the name.

[beomseoklee]

@Furytron I'm sorry to hear that you experienced an issue with Serverless Image Handler. I have reproduced this one, so we will be back soon for this issue.

[Furytron]

Thanks @beomseoklee !

[shortdoormedia]

@Furytron yeah, it doesn't matter if you are trying to resize, if your file name has dimensions in it, it thinks you are trying to resize. That is the issue.

[BuiltByJames]

Also getting this issue. Any update @beomseoklee ?

[beomseoklee]

I haven't tested whole cases, but simply, we can change the regular expression to this:

// thumbor-mapping.js
const dimPath = this.path.match(/\/((\d+x\d+)|(0x\d+))\//g);
if (dimPath) {
    const dims = dimPath[0].replace(/\//g, '').split('x');

I'll be back when I'm done the full testing.

[MaartenTutak]

Any updates? Running into the same issue here.

[beomseoklee]

Thanks for waiting. This one is fixed in v5.1.0.

[Furytron]

Thanks @beomseoklee !