Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbor remove EXIF data , images displayed rotated #240

Closed
eliavmaman opened this issue Oct 9, 2020 · 12 comments
Closed

Thumbor remove EXIF data , images displayed rotated #240

eliavmaman opened this issue Oct 9, 2020 · 12 comments
Labels

Comments

@eliavmaman
Copy link

eliavmaman commented Oct 9, 2020

I'm applying thumbor filters on s3 stored images.
Original : https://d37aahii0nv5jf.cloudfront.net/filters:strip_exif()/0Zoxha2t9S1HR4oYGmSa/IMG_9292.JPG
filter url file : https://d37aahii0nv5jf.cloudfront.net/fit-in/1000x0/filters:strip_exif()/0Zoxha2t9S1HR4oYGmSa/IMG_9292.JPG

image displayed rotated on our website.
Original:
image
on Website:
image
What should i do?
Really need to solv it

@eliavmaman eliavmaman added the bug label Oct 9, 2020
@beomseoklee
Copy link
Member

beomseoklee commented Oct 10, 2020

@eliavmaman I'm sorry to hear that you are experiencing the issue.
Would you mind sharing the original image, IMG_9292.JPG, so that I can reproduce? Meanwhile, I'm preparing a fix for this issue as you can see there are several same issues, so if you can provide the original image, I would see if the resolution would work.

@eliavmaman
Copy link
Author

Hey @beomseoklee Thx for the quick response, its really cool.
here is the original image .
I used to use the service of Cloudinary and i didn't had problems with EXIF... but now when i moves to AWS s3 with cloudfrontURL we do have this issue.
i've also tried to set environment variable of "RESPECT_ORIENTATION = True" but still have that problem.
Let me know if i can supply more details
Thx

@eliavmaman
Copy link
Author

@beomseoklee did you got the original image and is it ok for testing?

@beomseoklee
Copy link
Member

beomseoklee commented Oct 12, 2020

@eliavmaman Thanks for sharing.
I've tested the original image, and you can check the result.

https://d37r0g0z5f55a7.cloudfront.net/filters:strip_exif()/240.jpg
https://d37r0g0z5f55a7.cloudfront.net/fit-in/1000x0/filters:strip_exif()/240.jpg

So, I believe this issue would be fixed in the next release.
I cannot show the original image through the Serverless Image Handler solution due to a Lambda response payload size limit. Even though the actual image size is 4.8MB, when it is converted to base64, it's more than 6MB. But I hope the result that I share to you would be sufficient for you, which means we would fix this one in the next release.

@eliavmaman
Copy link
Author

@beomseoklee Thx man.. you are awesome and what you did is really appreciated.
Just 2 questions..
1.When does the next version will be?
2.Do i need to update something? i'm using the "serverless-image-handler" through installation of CloudPlatfrom template
Thx for your time

@beomseoklee
Copy link
Member

beomseoklee commented Oct 12, 2020

@eliavmaman We are planning to release the next version in this month, but it can be delayed. When we release the next version, what you need to do is to update using the latest CloudFormation template.

You can delete the images if it's sensitive for you.

@eliavmaman
Copy link
Author

eliavmaman commented Oct 26, 2020

Hey @beomseoklee
Just wanted to know if the bug was fixed and i can update my CloudFormation template?
Thx Man

@eliavmaman
Copy link
Author

@beomseoklee I have an open case on AWS which is related to that issue and could really use that next version in order to get my Site to work as expected.
Tell me if I can help to make the next version deploy my friend .
Appreciate your effort

@leviwilson
Copy link

@eliavmaman I have had way better luck with just deploying our PR branches rather than waiting on this particular repo to make a release.

PRs that are submitted here don't follow the normal release / merge cycles that most open source does in this regard. Instead I think they have internal flows w/ how changes with this particular repo are merged in that's independent of this repository.

I have had a few issues open for this and in some of them I outlined previously what I had done in order to deploy it myself. One example can be found here.

Best of luck.

@beomseoklee
Copy link
Member

@eliavmaman the bug is validated, and we are waiting for the next update. The next update would contain the fix of this issue.
@leviwilson I'm sorry for your bad experience, but you are right. Due to the internal policy, we don't manage this repository as other open source repositories in GitHub.

@leviwilson
Copy link

@beomseoklee it's fine; it would just be nice if that was outlined somewhere rather than people taking time to improve issues they find and not really have an idea how to get their changes into the mainline.

@beomseoklee
Copy link
Member

Thanks for waiting @eliavmaman
We've fixed this issue in v5.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants