Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality filter does not work with format filter (thumbor) #266

Closed
SNagappan opened this issue Feb 18, 2021 · 3 comments
Closed

Quality filter does not work with format filter (thumbor) #266

SNagappan opened this issue Feb 18, 2021 · 3 comments
Labels

Comments

@SNagappan
Copy link

The following ignores the quality filter when converting to jpg

{domain_name}/filters:format(jpeg)/filters:quality(50)/{key}

Looking at the source code https://github.com/awslabs/serverless-image-handler/blob/master/source/image-handler/thumbor-mapping.js#L173, the quality param is added based on file extension.

My expectation is that it would be added to this.edits.jpeg when format is specified.

@SNagappan SNagappan added the bug label Feb 18, 2021
@beomseoklee
Copy link
Member

@SNagappan Thanks for your feedback.

May I know what the original file format is? As far as I can test, it seems like if the original file format is PNG, than the quality does not work. I'll dig into this issue more.

@SNagappan
Copy link
Author

@beomseoklee It didn't work with png and it also didn't work with jpeg (with no file extension). I haven't tested with other formats but in my use case I need to convert a variety of different formats to jpeg.

@fisenkodv
Copy link
Contributor

@SNagappan, we have updated our solution, the issue has been fixed. If you still see the issue with the latest version (v6.0.0), please feel free to reopen the issue.

You can refer to the recent changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants