Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom rewrite does not work without file extensions #268

Closed
SNagappan opened this issue Feb 19, 2021 · 2 comments
Closed

custom rewrite does not work without file extensions #268

SNagappan opened this issue Feb 19, 2021 · 2 comments
Labels

Comments

@SNagappan
Copy link

The custom rewrite environment variables do not work if the key doesn't have a file extension.

https://github.com/awslabs/serverless-image-handler/blob/master/source/image-handler/image-request.js#L282 The regex checks if a file extension exists and custom request type is only selected if both the regex match and the environment variables are defined. Is the existence of the environment variables not a sufficient enough check? The regex limits it to keys with file extensions.

Is there any way to support custom expressions for keys without file extensions?

@SNagappan SNagappan added the bug label Feb 19, 2021
@DeccanAjay
Copy link

Thanks for the feedback. We will investigate and add this to our backlog.

@fisenkodv
Copy link
Contributor

@SNagappan we have updated our solution, and I believe your issue has been fixed. If you still see the issue with the latest version (v6.0.0), please feel free to reopen the issue.

You can refer to the recent changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants