-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image to composite must have same dimensions or smaller. #405
Comments
@tmihalik We will discuss this and get back to you |
This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
Hey, is there anything about this question? I have found a different solution for myself but I think this bug should be important for others. |
@tmihalik We are adding this to our backlog now and will let you know when we have a version that supports it. |
@tmihalik Could you provide the following information about this issue.
|
@tmihalik We discussed automatically cropping the overlay image down to the base image dimensions when it was larger and decided that would be a behavior change. Instead, we changed the error response to be more specific and indicate that it was a bad request and that the failure was due to the overlay image dimensions. The request in this case will still fail but it will note the actual cause. |
Hi, we're struggling with this issue long time ago. Couldn't find any answer besides that the issue is more or less known. We use different tricks to bypass it, but would be great to find a permanent solution within Sharp.
The problem occurs when we want to watermark different images. For that we're using the composite function which works great except when the overlaying layer's height is bigger than the original image. Even one pixel of difference makes crush the process, however didn't experience the same problem with widths. I think it would be a solution if the overlaying image would be cropped whenever it's necessary.
Any chance anyone has a proper solution (without changing the ratio)? Or the developers would consider to fix this problem?
Thank you in advance.
The text was updated successfully, but these errors were encountered: