Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo UI fails with unicode characters in the filename #416

Closed
batica81 opened this issue Dec 30, 2022 · 1 comment
Closed

Demo UI fails with unicode characters in the filename #416

batica81 opened this issue Dec 30, 2022 · 1 comment
Labels

Comments

@batica81
Copy link

Describe the bug
Demo UI fails when trying to read an image file unicode characters in the filename.

To Reproduce
Try naming the file something like čćšđ_unicode.jpg

Expected behavior
Filename should be processed no matter the characterset used.

Additional context

I managed to fix it by changing lines 24 and 86 from btoa(str) to btoa(unescape(encodeURIComponent(str)));
The deployment was done with Cloudformation template, and script.js file changed manually on S3.

I can create a PR if you want.

@batica81 batica81 added the bug label Dec 30, 2022
@dougtoppin
Copy link
Contributor

@batica81 Thank you for your report. We will duplicate it to confirm the issue.
We would appreciate a PR that includes the following if possible:

  • description of the issue
  • code changes made to correct the issue using the develop branch
  • test case descriptions to confirm the fix and confirm that the existing behavior continues to work for non-unicode characters

Once we get the PR we will add that to our backlog. We are working off the current list now but should be able to address this soon.
If we accept the PR we will give you a contributor attribution.

Thanks again for reporting this and providing a potential fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants