Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune SIGKILL timeout on a per ECS Task/Container Definition basis #1241

Closed
CpuID opened this issue Feb 19, 2018 · 10 comments
Closed

Tune SIGKILL timeout on a per ECS Task/Container Definition basis #1241

CpuID opened this issue Feb 19, 2018 · 10 comments

Comments

@CpuID
Copy link

CpuID commented Feb 19, 2018

Summary

Tune SIGKILL timeout on a per ECS Task/Container Definition basis, as opposed to Container Instance wide.

Description

Right now you can use an environment variable on the ECS Agent to tune the SIGKILL timeout sent for docker stop operations under the hood. This is ECS Agent wide, it would be extremely nice to be able to do this on a per Task or Container Definition basis.

See previous request with upvotes from others: #126 (comment)

@adnxn
Copy link
Contributor

adnxn commented Feb 20, 2018

@CpuID thanks for bringing this to our attention. I'm tagging this as a feature request for us to evaluate.

@CpuID
Copy link
Author

CpuID commented May 27, 2018

thx @adnxn any idea if this is on the nearish term roadmap...? (2018~)

@ellenthsu
Copy link

@CpuID - we need to evaluate the priority of this feature request, at this point in time, we cannot commit to a specific timeline. We'll update this thread once we prioritize this request. Thanks for understanding!

@CpuID
Copy link
Author

CpuID commented May 28, 2018

thx @ellenthsu

@themsaid
Copy link

themsaid commented Jun 21, 2018

With the EC2 launch type this can be configured using an environment variable, however with the fargate launch type there's no way of configuring this which was shocking given that fargate seems like the perfect choice for running a queue worker container, but the limit being too low may kill a long running job forcefully.

@CpuID
Copy link
Author

CpuID commented Jun 21, 2018

With the EC2 launch type this can be configured using an environment variable, however with the fargate launch type there's no way of configuring this which was shocking given that fargate seems like the perfect choice for running a queue worker container, but the limit being too low may kill a long running job forcefully.

Note, this issue is specifically about more granular tuning (vs global) on the EC2 launch type. I would assume adding support for SIGKILL tuning for Fargate might deserve it's own GitHub issue? Sounds like a valid feature request though :)

@coultn
Copy link

coultn commented Oct 31, 2018

For everyone interested in this issue, I wanted to let you know that the ECS team is aware of it, and that it is under active consideration. +1's and additional details on use cases are always appreciated and will help inform our work moving forward.

@cha7ri
Copy link

cha7ri commented Jan 28, 2019

Any updates on this issue? we have a use case where we need to stop gracefully a task but it needs more 30s to finish its work!
I know I can use the placement strategy to launch this service in a specific instances, but this will add more complexity and will not allow us to optimize the resources usage.
It will be really nice to be able to use the task definition to configure the stop timeout.

@adnxn
Copy link
Contributor

adnxn commented Feb 5, 2019

@cha7ri: we're planning to implement this as part of the container ordering. here's the proposal aws/containers-roadmap#123

@adnxn
Copy link
Contributor

adnxn commented Mar 6, 2019

closing issue, changes have been merged to dev with #1849 and expected to be released with agent v1.26.0

@adnxn adnxn closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants