Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CFS quota period configurable #1627

Closed
mseiwald opened this issue Oct 17, 2018 · 2 comments
Closed

Make CFS quota period configurable #1627

mseiwald opened this issue Oct 17, 2018 · 2 comments
Labels
kind/enhancement scope/ECS Agent

Comments

@mseiwald
Copy link

mseiwald commented Oct 17, 2018 •
edited
Loading

It seems that the CFS quota period is fixed in ecs agent for the parent cgroup that is created for each task.

amazon-ecs-agent/agent/api/task/task_linux.go

Line 39 in d68e729

defaultCPUPeriod = 100 * time.Millisecond // 100ms

Since the length of this period can have consequences on performance (see this and this) we would like it to be configurable, e.g. as an argument to ecs-agent.
@boynux boynux mentioned this issue Oct 18, 2018
Closed
8 tasks
@hjacobs
Copy link

hjacobs commented Nov 6, 2018 •
edited
Loading

Just FYI: we decided to completely disable CFS quota for all Zalando Kubernetes clusters: zalando-incubator/kubernetes-on-aws#1026

So I guess this should also be an option to consider.

@boynux boynux mentioned this issue Mar 15, 2019
Merged
@adnxn
Copy link
Contributor

adnxn commented Apr 29, 2019

closing since merged to dev with #1941

@adnxn adnxn closed this as completed Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement scope/ECS Agent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hjacobs @adnxn @mseiwald @samuelkarp