Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should validate CNI plugin during agent initialization. Refactor agent_capability related tests. #1893

Closed
suneyz opened this issue Feb 26, 2019 · 2 comments

Comments

@suneyz
Copy link
Contributor

suneyz commented Feb 26, 2019

Summary

  1. Lots of tests in here are linux specific, we should refactor them into agent_capability_unix_test file. Only keep common test for both linux and windows in agent_capability_test
  2. Currently we don't verify CNI plugins binary on agent start up. Currently only when in AWSVPC mode, agent will invoke capabilities command in verifyCNIPluginsCapabilities here We should always validate all the plugin binaries during agent start up (by invoking version command). Including
// a. ecs-eni
// b. ecs-bridge
// c. ecs-ipam
// d. aws-appmesh

Description

Expected Behavior

Observed Behavior

Environment Details

Supporting Log Snippets

@jy19
Copy link
Contributor

jy19 commented Nov 8, 2019

part 1 has been done by meghna here: #2070

@jy19
Copy link
Contributor

jy19 commented Dec 3, 2019

Discussed with Derek and Eric, part 2 is not needed at this time because plugin binaries are only required for AWSVPC mode and the presence of binaries are tested implicitly with our functional tests when agent starts up.
See:
eni
app-mesh
ecs-bridge, ecs-ipam

@jy19 jy19 closed this as completed Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants