gMSA support on Linux - capability advertisement #3445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fierlion
reviewed
Oct 25, 2022
saikiranakula-amzn
force-pushed
the
feature/gmsa-linux-init-module
branch
2 times, most recently
from
dd9ed75 to
5abd77e
Compare
sparrc
reviewed
Oct 25, 2022
sparrc
reviewed
Oct 25, 2022
sparrc
reviewed
Oct 25, 2022
sparrc
reviewed
Oct 25, 2022
sparrc
reviewed
Oct 25, 2022
sparrc
reviewed
Oct 25, 2022
sparrc
reviewed
Oct 25, 2022
sparrc
reviewed
Oct 25, 2022
singholt
reviewed
Oct 25, 2022
sparrc
reviewed
Oct 25, 2022
sparrc
reviewed
Oct 25, 2022
sparrc
reviewed
Oct 25, 2022
saikiranakula-amzn
force-pushed
the
feature/gmsa-linux-init-module
branch
2 times, most recently
from
69fb3fb to
bc458ed
Compare
sparrc
reviewed
Oct 25, 2022
saikiranakula-amzn
force-pushed
the
feature/gmsa-linux-init-module
branch
from
bc458ed to
f550b68
Compare
sparrc
previously approved these changes
Oct 25, 2022
singholt
reviewed
Oct 25, 2022
singholt
reviewed
Oct 25, 2022
saikiranakula-amzn
force-pushed
the
feature/gmsa-linux-init-module
branch
from
f550b68 to
e2e5955
Compare
singholt
reviewed
Oct 25, 2022
singholt
reviewed
Oct 25, 2022
singholt
reviewed
Oct 26, 2022
saikiranakula-amzn
force-pushed
the
feature/gmsa-linux-init-module
branch
2 times, most recently
from
713a8a5 to
52558ca
Compare
*changes to ecs-init to establish communication of agent with credentials-fetcher daemon *changes to agent to advertise gMSA capability on Linux
saikiranakula-amzn
force-pushed
the
feature/gmsa-linux-init-module
branch
from
52558ca to
17355e1
Compare
singholt
approved these changes
Oct 26, 2022
sparrc
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gMSA support on Linux - capability advertisement
*changes to ecs-init to establish communication of agent with credentials-fetcher daemon
*changes to agent to advertise gMSA capability on Linux
Summary
Agent to advertise gMSA support on Linux
Implementation details
*changes to ecs-init to establish communication of agent with credentials-fetcher daemon
*changes to agent to advertise gMSA capability on Linux
Testing
Added unit test to validate the funtionality
Note for external contributors:
make testandmake run-integ-testscan run in a Linux developmentenvironment like your laptop.
go test -timeout=30s ./agent/...and.\scripts\run-integ.tests.ps1can run in a Windows development environmentlike your laptop. Please ensure unit and integration tests pass (on at least
one platform) before opening the pull request.
Once you open the pull request, there will be 14 automatic test checks on the bottom
of the pull request, please make sure they all pass before you merge it. You can
use
bot/testlabel to rerun the automatic tests multiple times.-->
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.