Common functions to support gMSA linux #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikiranakula-amzn
force-pushed
the
feature/gmsa-linux-config
branch
4 times, most recently
from
234e6a3 to
b933106
Compare
singholt
reviewed
Oct 27, 2022
singholt
reviewed
Oct 27, 2022
saikiranakula-amzn
force-pushed
the
feature/gmsa-linux-config
branch
6 times, most recently
from
7c1e771 to
d19ba33
Compare
singholt
reviewed
Oct 27, 2022
saikiranakula-amzn
force-pushed
the
feature/gmsa-linux-config
branch
from
d19ba33 to
eb14d7a
Compare
singholt
approved these changes
Oct 27, 2022
sparrc
approved these changes
Oct 28, 2022
ubhattacharjya
approved these changes
Oct 28, 2022
singholt
pushed a commit
that referenced
this pull request
Nov 2, 2022
saikiranakula-amzn
added a commit
to saikiranakula-amzn/amazon-ecs-agent
that referenced
this pull request
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved functions to common files needed for supporting both windows and linux gMSA and refactored the s3 module in agent, to be more consistent with naming as per other aws modules in the code base
Implementation details
Renamed existing s3client to s3managerclient
Added new s3client to support get object from s3
Moved credentialspec code to common go files
Testing
Added unit tests
Note for external contributors:
make testandmake run-integ-testscan run in a Linux developmentenvironment like your laptop.
go test -timeout=30s ./agent/...and.\scripts\run-integ.tests.ps1can run in a Windows development environmentlike your laptop. Please ensure unit and integration tests pass (on at least
one platform) before opening the pull request.
Once you open the pull request, there will be 14 automatic test checks on the bottom
of the pull request, please make sure they all pass before you merge it. You can
use
bot/testlabel to rerun the automatic tests multiple times.-->
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.