fix: commit transaction after topology query (fixes #1168) #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @finalchild, I believe the fix for this has been merged already (see here). Are you okay with me closing this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR tries to fix #1168, where
queryForTopologyautomatically fired by FailOverPlugin opens a transaction and never closes, resulting in an unexpected change in the connection state.Description
If the connection doesn't auto-commit and wasn't in a transaction already,
queryForTopologyleaves a new transaction open. We have to either commit or roll back the transaction.Note that this PR is a suggestion merely based on a speculation. I haven't tested that this works, nor do I fully understand the meaning of
this.hostListProviderService.isInTransaction(). Please review and close/edit as you see fit.Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.